unistack-org/micro
4
0
Fork 3
Code Issues 14 Pull Requests 1 Actions Packages Projects Releases 252 Wiki Activity

[BUG] tracer проверять на дубликаты key-val пар при вызове Finish в спанах #347

New Issue
Closed
opened 2024-09-16 13:04:12 +03:00 by vtolstov · 2 comments
vtolstov commented 2024-09-16 13:04:12 +03:00
Owner
Copy Link

Как минимум для opentracing трейсера можно лейблы задать при старте спана, отдельным методом, и при завершении спана. Требуется при вызове Finish трекать уникальные key-val и не допускать запси одни и тех же ключ-значений в один спан. (вполне валидно иметь один и тот же ключ и два разных значения, но я думаю что лучше это тоже убрать и использовать только последнее значение).

Правки должны быть для
micro-tracer-opentracing
micro-tracer-instana (правки почти идентичные как и для opentracing)

Как минимум для opentracing трейсера можно лейблы задать при старте спана, отдельным методом, и при завершении спана. Требуется при вызове Finish трекать уникальные key-val и не допускать запси одни и тех же ключ-значений в один спан. (вполне валидно иметь один и тот же ключ и два разных значения, но я думаю что лучше это тоже убрать и использовать только последнее значение). Правки должны быть для micro-tracer-opentracing micro-tracer-instana (правки почти идентичные как и для opentracing)
vtolstov added this to the micro project 2024-09-16 13:04:12 +03:00
kgorbunov was assigned by vtolstov 2024-09-16 13:05:44 +03:00
vtolstov referenced this issue from a commit 2024-09-16 15:00:01 +03:00
#347 add test
kgorbunov commented 2024-09-16 15:00:55 +03:00
Member
Copy Link

mr micro - #349
mr micro-tracer-opentracing - unistack-org/micro-tracer-opentracing#47
mr micro-tracer-instana - unistack-org/micro-tracer-instana#1

mr micro - https://git.unistack.org/unistack-org/micro/pulls/349 mr micro-tracer-opentracing - https://git.unistack.org/unistack-org/micro-tracer-opentracing/pulls/47 mr micro-tracer-instana - https://git.unistack.org/unistack-org/micro-tracer-instana/pulls/1
kgorbunov added spent time 2024-09-16 15:01:07 +03:00
40 minutes
vtolstov commented 2024-09-16 15:02:00 +03:00
Author
Owner
Copy Link

done

done
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
micro
Assignees
Clear assignees
No Assignees
kgorbunov
2 Participants
Notifications
Total Time Spent: 40 minutes
kgorbunov
40 minutes
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: unistack-org/micro#347
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?