unistack-org/pofile
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix default value of msgctxt field

Browse Source 
I added a few more edge-cases to the tests for the new msgctxt field and
revealed a bug during that. The default value has been set to empty
string, but should have been null, since the spec says, this field is
optional.
This commit is contained in:
Julian Bäume 2014-01-22 14:10:15 +01:00
parent abca810905
commit a5f3059661
2 changed files with 24 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/po.js
View File

@ -164,7 +164,7 @@ PO.parse = function (data) {
PO.Item = function () {
this.msgid = '';
this.msgctxt = '';
this.msgctxt = null;
this.references = [];
this.msgid_plural = null;
this.msgstr = [];

28
test/write.js
View File

@ -38,10 +38,28 @@ describe('Write', function () {
assertHasLine(str, "msgstr \"Source\"");
});
it('write msgctxt', function () {
var input = fs.readFileSync(__dirname + '/fixtures/big.po', 'utf8');
var po = PO.parse(input);
var str = po.toString();
assertHasLine(str, 'msgctxt "folder action"');
describe('msgctxt', function () {
it('should write context field to file', function () {
var input = fs.readFileSync(__dirname + '/fixtures/big.po', 'utf8');
var po = PO.parse(input);
var str = po.toString();
assertHasLine(str, 'msgctxt "folder action"');
});
it('should ignore omitted context field', function () {
var po = new PO();
var item = new PO.Item();
po.items.push(item);
assert.ok(po.toString().indexOf('msgctxt') < 0);
});
it('should write empty context field', function () {
var po = new PO();
var item = new PO.Item();
item.msgctxt = '';
po.items.push(item);
assert.ok(po.toString().indexOf('msgctxt') >= 0);
});
});
});