unistack-org/pofile
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix the async calls.

Browse Source 
This is a breaking change. But that's okay, the previous behavior for
async was just plain wrong and would crash the entire node process,
which is unacceptable. A major version bump will be needed to release
this.
This commit is contained in:
Ruben Vermeersch 2013-12-17 14:30:07 +01:00
parent e61e535a79
commit fe2e17990a
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/po.js
View File

@ -12,15 +12,7 @@ var PO = function () {
}; };
PO.prototype.save = function (filename, callback) { PO.prototype.save = function (filename, callback) {
fs.writeFile(filename, this.toString(), function (err) { fs.writeFile(filename, this.toString(), callback);
if (err) {
throw err;
}
if (callback) {
callback();
}
});
}; };
PO.prototype.toString = function () { PO.prototype.toString = function () {
@ -54,10 +46,10 @@ PO.prototype.toString = function () {
PO.load = function (filename, callback) { PO.load = function (filename, callback) {
fs.readFile(filename, 'utf-8', function (err, data) { fs.readFile(filename, 'utf-8', function (err, data) {
if (err) { if (err) {
throw err; return callback(err);
} }
var po = PO.parse(data); var po = PO.parse(data);
callback(po); callback(null, po);
}); });
}; };