From c7ec840ac0ad9f4721d326fc04a7980f39e318e2 Mon Sep 17 00:00:00 2001
From: Vasiliy Tolstov <v.tolstov@unistack.org>
Date: Tue, 23 Mar 2021 16:56:11 +0300
Subject: [PATCH] remove some runtime allocaions

Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
---
 util.go | 32 ++++++++++++++++++++++++++++----
 1 file changed, 28 insertions(+), 4 deletions(-)

diff --git a/util.go b/util.go
index 52b9560..a28b749 100644
--- a/util.go
+++ b/util.go
@@ -10,6 +10,20 @@ import (
 	"google.golang.org/protobuf/proto"
 )
 
+var (
+	httpMethodMap = map[string]string{
+		"GET":     "MethodGet",
+		"HEAD":    "MethodHead",
+		"POST":    "MethodPost",
+		"PUT":     "MethodPut",
+		"PATCH":   "MethodPatch",
+		"DELETE":  "MethodDelete",
+		"CONNECT": "MethodConnect",
+		"OPTIONS": "MethodOptions",
+		"TRACE":   "MethodTrace",
+	}
+)
+
 func unexport(s string) string {
 	return strings.ToLower(s[:1]) + s[1:]
 }
@@ -61,9 +75,15 @@ func generateServiceClientMethods(gfile *protogen.GeneratedFile, service *protog
 				gfile.P("opts = append(opts,")
 				endpoints, _ := generateEndpoints(method)
 				path, method, body := getEndpoint(endpoints[0])
-				gfile.P(microClientHttpPackage.Ident("Method"), `("`, method, `"),`)
+				if vmethod, ok := httpMethodMap[method]; ok {
+					gfile.P(microClientHttpPackage.Ident("Method"), `(`, httpPackage.Ident(vmethod), `),`)
+				} else {
+					gfile.P(microClientHttpPackage.Ident("Method"), `("`, method, `"),`)
+				}
 				gfile.P(microClientHttpPackage.Ident("Path"), `("`, path, `"),`)
-				gfile.P(microClientHttpPackage.Ident("Body"), `("`, body, `"),`)
+				if body != "" {
+					gfile.P(microClientHttpPackage.Ident("Body"), `("`, body, `"),`)
+				}
 				gfile.P(")")
 			}
 		}
@@ -539,8 +559,12 @@ func generateEndpoint(gfile *protogen.GeneratedFile, serviceName string, methodN
 	path, meth, body := getEndpoint(rule)
 	gfile.P("Name:", fmt.Sprintf(`"%s.%s",`, serviceName, methodName))
 	gfile.P("Path:", fmt.Sprintf(`[]string{"%s"},`, path))
-	gfile.P("Method:", fmt.Sprintf(`[]string{"%s"},`, meth))
-	if len(rule.GetGet()) == 0 {
+	if vmethod, ok := httpMethodMap[meth]; ok {
+		gfile.P("Method:", `[]string{`, httpPackage.Ident(vmethod), `},`)
+	} else {
+		gfile.P("Method:", fmt.Sprintf(`[]string{"%s"},`, meth))
+	}
+	if len(rule.GetGet()) == 0 && body != "" {
 		gfile.P("Body:", fmt.Sprintf(`"%s",`, body))
 	}
 	if streaming {