2017-03-31 18:01:58 +02:00
|
|
|
package log_test
|
|
|
|
|
|
|
|
import (
|
|
|
|
"bytes"
|
|
|
|
"fmt"
|
|
|
|
"sync"
|
|
|
|
"testing"
|
|
|
|
|
|
|
|
"github.com/go-kit/kit/log"
|
|
|
|
"github.com/go-stack/stack"
|
|
|
|
)
|
|
|
|
|
|
|
|
func TestContext(t *testing.T) {
|
|
|
|
t.Parallel()
|
|
|
|
buf := &bytes.Buffer{}
|
|
|
|
logger := log.NewLogfmtLogger(buf)
|
|
|
|
|
|
|
|
kvs := []interface{}{"a", 123}
|
2017-05-18 18:54:23 +02:00
|
|
|
lc := log.NewContext(logger).With(kvs...)
|
2017-03-31 18:01:58 +02:00
|
|
|
kvs[1] = 0 // With should copy its key values
|
|
|
|
|
2017-05-18 18:54:23 +02:00
|
|
|
lc = lc.With("b", "c") // With should stack
|
2017-03-31 18:01:58 +02:00
|
|
|
if err := lc.Log("msg", "message"); err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
if want, have := "a=123 b=c msg=message\n", buf.String(); want != have {
|
|
|
|
t.Errorf("\nwant: %shave: %s", want, have)
|
|
|
|
}
|
|
|
|
|
|
|
|
buf.Reset()
|
2017-05-18 18:54:23 +02:00
|
|
|
lc = lc.WithPrefix("p", "first")
|
2017-03-31 18:01:58 +02:00
|
|
|
if err := lc.Log("msg", "message"); err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
if want, have := "p=first a=123 b=c msg=message\n", buf.String(); want != have {
|
|
|
|
t.Errorf("\nwant: %shave: %s", want, have)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestContextMissingValue(t *testing.T) {
|
|
|
|
t.Parallel()
|
|
|
|
var output []interface{}
|
|
|
|
logger := log.Logger(log.LoggerFunc(func(keyvals ...interface{}) error {
|
|
|
|
output = keyvals
|
|
|
|
return nil
|
|
|
|
}))
|
|
|
|
|
2017-05-18 18:54:23 +02:00
|
|
|
lc := log.NewContext(logger)
|
|
|
|
|
|
|
|
lc.Log("k")
|
|
|
|
if want, have := 2, len(output); want != have {
|
|
|
|
t.Errorf("want len(output) == %v, have %v", want, have)
|
|
|
|
}
|
|
|
|
if want, have := log.ErrMissingValue, output[1]; want != have {
|
|
|
|
t.Errorf("want %#v, have %#v", want, have)
|
|
|
|
}
|
|
|
|
|
|
|
|
lc.With("k1").WithPrefix("k0").Log("k2")
|
2017-03-31 18:01:58 +02:00
|
|
|
if want, have := 6, len(output); want != have {
|
|
|
|
t.Errorf("want len(output) == %v, have %v", want, have)
|
|
|
|
}
|
|
|
|
for i := 1; i < 6; i += 2 {
|
|
|
|
if want, have := log.ErrMissingValue, output[i]; want != have {
|
|
|
|
t.Errorf("want output[%d] == %#v, have %#v", i, want, have)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-05-18 18:54:23 +02:00
|
|
|
// Test that Context.Log has a consistent function stack depth when binding
|
|
|
|
// log.Valuers, regardless of how many times Context.With has been called or
|
|
|
|
// whether Context.Log is called via an interface typed variable or a concrete
|
|
|
|
// typed variable.
|
2017-03-31 18:01:58 +02:00
|
|
|
func TestContextStackDepth(t *testing.T) {
|
|
|
|
t.Parallel()
|
|
|
|
fn := fmt.Sprintf("%n", stack.Caller(0))
|
|
|
|
|
|
|
|
var output []interface{}
|
|
|
|
|
|
|
|
logger := log.Logger(log.LoggerFunc(func(keyvals ...interface{}) error {
|
|
|
|
output = keyvals
|
|
|
|
return nil
|
|
|
|
}))
|
|
|
|
|
|
|
|
stackValuer := log.Valuer(func() interface{} {
|
|
|
|
for i, c := range stack.Trace() {
|
|
|
|
if fmt.Sprintf("%n", c) == fn {
|
|
|
|
return i
|
|
|
|
}
|
|
|
|
}
|
|
|
|
t.Fatal("Test function not found in stack trace.")
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
|
2017-05-18 18:54:23 +02:00
|
|
|
concrete := log.NewContext(logger).With("stack", stackValuer)
|
|
|
|
var iface log.Logger = concrete
|
2017-03-31 18:01:58 +02:00
|
|
|
|
|
|
|
// Call through interface to get baseline.
|
2017-05-18 18:54:23 +02:00
|
|
|
iface.Log("k", "v")
|
2017-03-31 18:01:58 +02:00
|
|
|
want := output[1].(int)
|
|
|
|
|
|
|
|
for len(output) < 10 {
|
2017-05-18 18:54:23 +02:00
|
|
|
concrete.Log("k", "v")
|
|
|
|
if have := output[1]; have != want {
|
|
|
|
t.Errorf("%d Withs: have %v, want %v", len(output)/2-1, have, want)
|
|
|
|
}
|
|
|
|
|
|
|
|
iface.Log("k", "v")
|
2017-03-31 18:01:58 +02:00
|
|
|
if have := output[1]; have != want {
|
|
|
|
t.Errorf("%d Withs: have %v, want %v", len(output)/2-1, have, want)
|
|
|
|
}
|
|
|
|
|
2017-05-18 18:54:23 +02:00
|
|
|
wrapped := log.NewContext(concrete)
|
2017-03-31 18:01:58 +02:00
|
|
|
wrapped.Log("k", "v")
|
|
|
|
if have := output[1]; have != want {
|
|
|
|
t.Errorf("%d Withs: have %v, want %v", len(output)/2-1, have, want)
|
|
|
|
}
|
|
|
|
|
2017-05-18 18:54:23 +02:00
|
|
|
concrete = concrete.With("k", "v")
|
|
|
|
iface = concrete
|
2017-03-31 18:01:58 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test that With returns a Logger safe for concurrent use. This test
|
|
|
|
// validates that the stored logging context does not get corrupted when
|
|
|
|
// multiple clients concurrently log additional keyvals.
|
|
|
|
//
|
|
|
|
// This test must be run with go test -cpu 2 (or more) to achieve its goal.
|
|
|
|
func TestWithConcurrent(t *testing.T) {
|
|
|
|
// Create some buckets to count how many events each goroutine logs.
|
|
|
|
const goroutines = 8
|
|
|
|
counts := [goroutines]int{}
|
|
|
|
|
|
|
|
// This logger extracts a goroutine id from the last value field and
|
|
|
|
// increments the referenced bucket.
|
|
|
|
logger := log.LoggerFunc(func(kv ...interface{}) error {
|
|
|
|
goroutine := kv[len(kv)-1].(int)
|
|
|
|
counts[goroutine]++
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
|
|
|
|
// With must be careful about handling slices that can grow without
|
|
|
|
// copying the underlying array, so give it a challenge.
|
2017-05-18 18:54:23 +02:00
|
|
|
l := log.NewContext(logger).With(make([]interface{}, 0, 2)...)
|
2017-03-31 18:01:58 +02:00
|
|
|
|
|
|
|
// Start logging concurrently. Each goroutine logs its id so the logger
|
|
|
|
// can bucket the event counts.
|
|
|
|
var wg sync.WaitGroup
|
|
|
|
wg.Add(goroutines)
|
|
|
|
const n = 10000
|
|
|
|
for i := 0; i < goroutines; i++ {
|
|
|
|
go func(idx int) {
|
|
|
|
defer wg.Done()
|
|
|
|
for j := 0; j < n; j++ {
|
|
|
|
l.Log("goroutineIdx", idx)
|
|
|
|
}
|
|
|
|
}(i)
|
|
|
|
}
|
|
|
|
wg.Wait()
|
|
|
|
|
|
|
|
for bucket, have := range counts {
|
|
|
|
if want := n; want != have {
|
|
|
|
t.Errorf("bucket %d: want %d, have %d", bucket, want, have) // note Errorf
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func BenchmarkDiscard(b *testing.B) {
|
|
|
|
logger := log.NewNopLogger()
|
|
|
|
b.ReportAllocs()
|
|
|
|
b.ResetTimer()
|
|
|
|
for i := 0; i < b.N; i++ {
|
|
|
|
logger.Log("k", "v")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func BenchmarkOneWith(b *testing.B) {
|
|
|
|
logger := log.NewNopLogger()
|
2017-05-18 18:54:23 +02:00
|
|
|
lc := log.NewContext(logger).With("k", "v")
|
2017-03-31 18:01:58 +02:00
|
|
|
b.ReportAllocs()
|
|
|
|
b.ResetTimer()
|
|
|
|
for i := 0; i < b.N; i++ {
|
|
|
|
lc.Log("k", "v")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func BenchmarkTwoWith(b *testing.B) {
|
|
|
|
logger := log.NewNopLogger()
|
2017-05-18 18:54:23 +02:00
|
|
|
lc := log.NewContext(logger).With("k", "v")
|
2017-03-31 18:01:58 +02:00
|
|
|
for i := 1; i < 2; i++ {
|
2017-05-18 18:54:23 +02:00
|
|
|
lc = lc.With("k", "v")
|
2017-03-31 18:01:58 +02:00
|
|
|
}
|
|
|
|
b.ReportAllocs()
|
|
|
|
b.ResetTimer()
|
|
|
|
for i := 0; i < b.N; i++ {
|
|
|
|
lc.Log("k", "v")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func BenchmarkTenWith(b *testing.B) {
|
|
|
|
logger := log.NewNopLogger()
|
2017-05-18 18:54:23 +02:00
|
|
|
lc := log.NewContext(logger).With("k", "v")
|
2017-03-31 18:01:58 +02:00
|
|
|
for i := 1; i < 10; i++ {
|
2017-05-18 18:54:23 +02:00
|
|
|
lc = lc.With("k", "v")
|
2017-03-31 18:01:58 +02:00
|
|
|
}
|
|
|
|
b.ReportAllocs()
|
|
|
|
b.ResetTimer()
|
|
|
|
for i := 0; i < b.N; i++ {
|
|
|
|
lc.Log("k", "v")
|
|
|
|
}
|
|
|
|
}
|