Bump github.com/twmb/franz-go from 1.10.4 to 1.11.5 #106

vtolstov · 2023-01-30T14:07:49+03:00

dependabot[bot] commented

2023-01-30 14:07:49 +03:00

(Migrated from github.com)

Bumps github.com/twmb/franz-go from 1.10.4 to 1.11.5.

Changelog

Sourced from github.com/twmb/franz-go's changelog.

v1.11.5

v1.11.4 is retracted and because it actually requires a v2 release. When a breaking kmsg release must happen, v2 of franz-go will happen and I will make a change thorough enough such that major kmsg changes will not require a major franz-go change again.

When this repo was initially written, the Kafka documentation for the wire serialization of a Kafka record was wrong and different from how things were actually implemented in the Java source. I used the documentation for my own implementation. The documentation was later fixed.

What this means is that in this repo, kmsg.Record.TimestampDelta should be changed from an int32 to int64. Rather than release a major version of kmsg, I have added a TimestampDelta64 field.

The old 32 bit timestamp delta meant that this package could only represent records that had up to 24 days of a delta within a batch. Apparently, this may happen in compacted topics.

More minor: previously, AddConsumeTopics did not work on direct consumers nor on a client that consumed nothing to begin with. These shortcomings have been addressed.

12e3c11 bugfix franz-go: support 64 bit timestamp deltas

f613fb8 bugfix pkg/kgo: patch AddConsumeTopics

v1.11.3

This patch release fixes a panic that can occur when fetching offsets in the following scenario:

You are fetching offsets for a group that the client has not yet loaded internally

The internal load's FindCoordinator request fails OR the group cannot be loaded

FindCoordinator usually does not fail outright because the request internally retries. As well, the group load is usually successful. Group loading only fails if you are unauthorized to describe the group or if the group coordinator is not loaded.

The most common case to encounter this error is when you issue a group request against a new cluster. The first time a group request is seen, the group coordinator loads. While loading, group requests are failed with COORDINATOR_LOAD_IN_PROGRESS or some other similar error.

5289ef6 bugfix kgo.Client: avoid panic in OffsetFetchRequest when coordinator is not loaded

... (truncated)

Commits

d812992 Merge pull request #335 from twmb/v1_11_5
5dd0150 CHANGELOG: note incoming v1.11.5
a0f2e5b franz-go: support 64 bit timestamp deltas
4219922 franz-go: pin kmsg to v1.3.0
ed99163 go.mod: retract v1.11.4
68a3431 Revert "pkg/kgo/source.go: remove unnecessary int64 conversion"
6ffa6e4 Revert "franz-go: bump kmsg to v2"
de0c56d Merge pull request #334 from twmb/kmsg_v1_again
aacfc8f pkg/kmsg: add Record.TimestampDelta64
3754ac1 pkg/kmsg: back out of v2
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/twmb/franz-go](https://github.com/twmb/franz-go) from 1.10.4 to 1.11.5. <details> <summary>Changelog</summary> Sourced from <a href="https://github.com/twmb/franz-go/blob/master/CHANGELOG.md">github.com/twmb/franz-go's changelog</a>. <blockquote> <h1>v1.11.5</h1> v1.11.4 is retracted and because it actually requires a v2 release. When a breaking kmsg release must happen, v2 of franz-go will happen and I will make a change thorough enough such that major kmsg changes will not require a major franz-go change again. When this repo was initially written, the Kafka documentation for the wire serialization of a Kafka record was wrong and different from how things were actually implemented in the Java source. I used the documentation for my own implementation. The documentation was <a href="https://github.com/apache/kafka/commit/94ccd4d">later fixed</a>. What this means is that in this repo, <code>kmsg.Record.TimestampDelta</code> should be changed from an int32 to int64. Rather than release a major version of kmsg, I have added a <code>TimestampDelta64</code> field. The old 32 bit timestamp delta meant that this package could only represent records that had up to 24 days of a delta within a batch. Apparently, this may happen in compacted topics. More minor: previously, <code>AddConsumeTopics</code> did not work on direct consumers nor on a client that consumed nothing to begin with. These shortcomings have been addressed. <ul> <li><a href="https://github.com/twmb/franz-go/commit/12e3c11"><code>12e3c11</code></a> bugfix franz-go: support 64 bit timestamp deltas</li> <li><a href="https://github.com/twmb/franz-go/commit/f613fb8"><code>f613fb8</code></a> bugfix pkg/kgo: patch AddConsumeTopics</li> </ul> <h1>v1.11.3</h1> This patch release fixes a panic that can occur when fetching offsets in the following scenario: <ul> <li>You are fetching offsets for a group that the client has not yet loaded internally</li> <li>The internal load's FindCoordinator request fails OR the group cannot be loaded</li> </ul> FindCoordinator usually does not fail outright because the request internally retries. As well, the group load is usually successful. Group loading only fails if you are unauthorized to describe the group or if the group coordinator is not loaded. The most common case to encounter this error is when you issue a group request against a new cluster. The first time a group request is seen, the group coordinator loads. While loading, group requests are failed with <code>COORDINATOR_LOAD_IN_PROGRESS</code> or some other similar error. <ul> <li><a href="https://github.com/twmb/franz-go/commit/5289ef6"><code>5289ef6</code></a> bugfix kgo.Client: avoid panic in OffsetFetchRequest when coordinator is not loaded</li> </ul>  </blockquote> ... (truncated) </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/twmb/franz-go/commit/d81299221435eba98af85d0ff2114a7660f940ee"><code>d812992</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/twmb/franz-go/issues/335">#335</a> from twmb/v1_11_5</li> <li><a href="https://github.com/twmb/franz-go/commit/5dd0150a65e15184aca3166c90ec7d2fddfbeb5f"><code>5dd0150</code></a> CHANGELOG: note incoming v1.11.5</li> <li><a href="https://github.com/twmb/franz-go/commit/a0f2e5bc4be0f27cd41fa46325c100bc9a6102d6"><code>a0f2e5b</code></a> franz-go: support 64 bit timestamp deltas</li> <li><a href="https://github.com/twmb/franz-go/commit/42199222f56deae2b988cc22a99b2febe6045898"><code>4219922</code></a> franz-go: pin kmsg to v1.3.0</li> <li><a href="https://github.com/twmb/franz-go/commit/ed991632a2c39f60d81e397be84eb9391d94186b"><code>ed99163</code></a> go.mod: retract v1.11.4</li> <li><a href="https://github.com/twmb/franz-go/commit/68a34318488e6a0607c68aadc4b6f90f96316b8c"><code>68a3431</code></a> Revert "pkg/kgo/source.go: remove unnecessary int64 conversion"</li> <li><a href="https://github.com/twmb/franz-go/commit/6ffa6e41a5ab279cbc60f93386c19edbd67083a8"><code>6ffa6e4</code></a> Revert "franz-go: bump kmsg to v2"</li> <li><a href="https://github.com/twmb/franz-go/commit/de0c56d25a94d5ee8c2aef50b5b114b42680e980"><code>de0c56d</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/twmb/franz-go/issues/334">#334</a> from twmb/kmsg_v1_again</li> <li><a href="https://github.com/twmb/franz-go/commit/aacfc8f461d1919e230742bff1a651e041b67203"><code>aacfc8f</code></a> pkg/kmsg: add Record.TimestampDelta64</li> <li><a href="https://github.com/twmb/franz-go/commit/3754ac1565a06b60a530489917970a0a243e4dc8"><code>3754ac1</code></a> pkg/kmsg: back out of v2</li> <li>Additional commits viewable in <a href="https://github.com/twmb/franz-go/compare/v1.10.4...v1.11.5">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/twmb/franz-go&package-manager=go_modules&previous-version=1.10.4&new-version=1.11.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

github-actions[bot] (Migrated from github.com) reviewed 2023-01-30 14:08:08 +03:00

github-actions[bot] (Migrated from github.com) reviewed 2023-01-30 14:15:46 +03:00

github-actions[bot] (Migrated from github.com) reviewed 2023-01-30 21:18:04 +03:00

github-actions[bot] (Migrated from github.com) reviewed 2023-01-30 21:26:34 +03:00

vtolstov commented

2023-01-31 06:51:42 +03:00

(Migrated from github.com)

@dependabot recreate

👍 1

github-actions[bot] (Migrated from github.com) approved these changes 2023-01-31 06:52:20 +03:00

vtolstov referenced this issue from a commit

2023-04-28 22:51:13 +03:00