Bump github.com/twmb/franz-go from 1.11.5 to 1.12.1 #116

vtolstov · 2023-02-17T14:59:03+03:00

dependabot[bot] commented

2023-02-17 14:59:03 +03:00

(Migrated from github.com)

Bumps github.com/twmb/franz-go from 1.11.5 to 1.12.1.

Changelog

Sourced from github.com/twmb/franz-go's changelog.

v1.12.1

This patch adds back the pre-v1.11.7 behavior of returning UNKNOWN_TOPIC_ID when consuming. Patch v1.11.7 explicitly stripped this error because it was found during testing that Kafka 3.4 now returns the error occasionally when immediately consuming from a new topic (i.e. in tests), and the error is explicitly marked as retryable within the Kafka source code. However, with topic IDs, there is no way for a client to recover if the topic has been deleted and recreated. By returning the error, end users can notified that their client is in a fatal state and they should restart. In the future, I will add an option to consume recreated topics.

efe1cdb consumer: return UnknownTopicID even though it is retryable

v1.12.0

This release is tested against Kafka 3.4, and kversion can now properly version guess 3.4. There are two external kgo features in this release and there is one internal feature.

Externally,

Client.CommitMarkedOffsets makes committing marked offsets a bit easier

Client.UpdateSeedBrokers allows for updating seed brokers, which can be useful on extremely long lived clients.

Internally,

KIP-792 improves fencing of zombie group consumers using cooperative rebalancing

c5f86ea feature kgo.Client: add UpdateSeedBrokers(...string) error

3e45339 internal improvement group balancer: support KIP-792

fe727f8 feature kversion: cut Kafka 3.4

6751589 feature pkg/kgo: add Client.CommitMarkedOffsets (thanks @celrenheit!)

v1.11.7

The integration test introduced in v1.11.6 was frequently failing in CI. After some investigation, the panic is caused from PurgeTopicsFromClient while a load of offsets was happening (i.e. consuming was being initialized). That race is specifically easily triggered in the integration test.

This patch also relaxes the error stripping while consuming. While consuming, retryable errors are stripped. The errors that were stripped was a small specific set that was originally taken from Sarama (nearly 4yr ago). Kafka 3.4 returns a new retryable error frequently if consuming against a topic immediately after the topic is created. This patch changes the error set to just strip all retryable errors, since the kerr package already indicates which

... (truncated)

Commits

3322f31 Merge pull request #363 from twmb/changelog_v1.12.1
740f6a3 CHANGELOG: note incoming v1.12.1
35cdb3f Merge pull request #362 from twmb/sticky_userdata
887bed5 sticky: decode userdata directly to avoid allocs
88d54f2 Merge pull request #360 from twmb/tidy_examples
9e752ef README: bump some version numbers
49fa716 examples: remove replace directives and tidy
e91d76d Merge pull request #359 from twmb/unknown_topic_id
598ace0 consumer: preemptively avoid a panic
efe1cdb consumer: return UnknownTopicID even though it is retryable
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/twmb/franz-go](https://github.com/twmb/franz-go) from 1.11.5 to 1.12.1. <details> <summary>Changelog</summary> Sourced from <a href="https://github.com/twmb/franz-go/blob/master/CHANGELOG.md">github.com/twmb/franz-go's changelog</a>. <blockquote> <h1>v1.12.1</h1> This patch adds back the pre-v1.11.7 behavior of returning <code>UNKNOWN_TOPIC_ID</code> when consuming. Patch v1.11.7 explicitly stripped this error because it was found during testing that Kafka 3.4 now returns the error occasionally when immediately consuming from a new topic (i.e. in tests), and the error is explicitly marked as retryable within the Kafka source code. However, with topic IDs, there is no way for a client to recover if the topic has been deleted and recreated. By returning the error, end users can notified that their client is in a fatal state and they should restart. In the future, I will add an option to consume recreated topics. <ul> <li><a href="https://github.com/twmb/franz-go/commit/efe1cdb"><code>efe1cdb</code></a> consumer: return UnknownTopicID even though it is retryable</li> </ul> <h1>v1.12.0</h1> This release is tested against Kafka 3.4, and kversion can now properly version guess 3.4. There are two external kgo features in this release and there is one internal feature. Externally, <ul> <li><code>Client.CommitMarkedOffsets</code> makes committing marked offsets a bit easier</li> <li><code>Client.UpdateSeedBrokers</code> allows for updating seed brokers, which can be useful on extremely long lived clients.</li> </ul> Internally, <ul> <li>KIP-792 improves fencing of zombie group consumers using cooperative rebalancing</li> </ul> <ul> <li><a href="https://github.com/twmb/franz-go/commit/c5f86ea"><code>c5f86ea</code></a> feature kgo.Client: add <code>UpdateSeedBrokers(...string) error</code></li> <li><a href="https://github.com/twmb/franz-go/commit/3e45339"><code>3e45339</code></a> internal improvement group balancer: support KIP-792</li> <li><a href="https://github.com/twmb/franz-go/commit/fe727f8"><code>fe727f8</code></a> feature kversion: cut Kafka 3.4</li> <li><a href="https://github.com/twmb/franz-go/commit/6751589"><code>6751589</code></a> feature pkg/kgo: add <code>Client.CommitMarkedOffsets</code> (thanks <a href="https://github.com/celrenheit"><code>@celrenheit</code></a>!)</li> </ul> <h1>v1.11.7</h1> The integration test introduced in v1.11.6 was frequently failing in CI. After some investigation, the panic is caused from <code>PurgeTopicsFromClient</code> while a load of offsets was happening (i.e. consuming was being initialized). That race is specifically easily triggered in the integration test. This patch also relaxes the error stripping while consuming. While consuming, retryable errors are stripped. The errors that were stripped was a small specific set that was originally taken from Sarama (nearly 4yr ago). Kafka 3.4 returns a new retryable error frequently if consuming against a topic immediately after the topic is created. This patch changes the error set to just strip all retryable errors, since the kerr package already indicates which  </blockquote> ... (truncated) </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/twmb/franz-go/commit/3322f311fd833129f91b4ea76581150274bdb457"><code>3322f31</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/twmb/franz-go/issues/363">#363</a> from twmb/changelog_v1.12.1</li> <li><a href="https://github.com/twmb/franz-go/commit/740f6a3685215308ef7d4aa29f270732c288266c"><code>740f6a3</code></a> CHANGELOG: note incoming v1.12.1</li> <li><a href="https://github.com/twmb/franz-go/commit/35cdb3f44ecdc3518111e94f4da78b5d043fe5f6"><code>35cdb3f</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/twmb/franz-go/issues/362">#362</a> from twmb/sticky_userdata</li> <li><a href="https://github.com/twmb/franz-go/commit/887bed59203de4cec05904715b05cb247d3c172e"><code>887bed5</code></a> sticky: decode userdata directly to avoid allocs</li> <li><a href="https://github.com/twmb/franz-go/commit/88d54f20d798b45d712b3eb5c4738f19daaf4e6a"><code>88d54f2</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/twmb/franz-go/issues/360">#360</a> from twmb/tidy_examples</li> <li><a href="https://github.com/twmb/franz-go/commit/9e752ef391c584cf28caef228d5ab8bfe57346b4"><code>9e752ef</code></a> README: bump some version numbers</li> <li><a href="https://github.com/twmb/franz-go/commit/49fa7164bb2751069929f145d291c9cef09c7878"><code>49fa716</code></a> examples: remove replace directives and tidy</li> <li><a href="https://github.com/twmb/franz-go/commit/e91d76dfbc5e09923a3f152c8964dda9b170f826"><code>e91d76d</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/twmb/franz-go/issues/359">#359</a> from twmb/unknown_topic_id</li> <li><a href="https://github.com/twmb/franz-go/commit/598ace057ef4a224a4f6a2fbf591d3296c920c6e"><code>598ace0</code></a> consumer: preemptively avoid a panic</li> <li><a href="https://github.com/twmb/franz-go/commit/efe1cdbf89b31b87a815ae85cf4c8ceb1392abda"><code>efe1cdb</code></a> consumer: return UnknownTopicID even though it is retryable</li> <li>Additional commits viewable in <a href="https://github.com/twmb/franz-go/compare/v1.11.5...v1.12.1">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/twmb/franz-go&package-manager=go_modules&previous-version=1.11.5&new-version=1.12.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

github-actions[bot] (Migrated from github.com) reviewed 2023-02-17 14:59:18 +03:00

github-actions[bot] (Migrated from github.com) reviewed 2023-02-21 15:05:59 +03:00

github-actions[bot] (Migrated from github.com) reviewed 2023-02-22 15:03:49 +03:00

github-actions[bot] (Migrated from github.com) approved these changes 2023-02-27 15:14:23 +03:00

vtolstov closed this pull request

2023-05-13 15:39:34 +03:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: unistack-org/micro-broker-kgo#116