unistack-org/micro-broker-kgo
4
0
Fork 2
Code Issues 3 Pull Requests 2 Actions Packages Projects Releases 73 Wiki Activity

added check span!=nil && conn close #154

Merged
vtolstov merged 2 commits from devstigneev/micro-broker-kgo:v3 into v3 2025-05-21 11:56:48 +03:00
Conversation 1 Commits 2 Files Changed 2 +34 -24
devstigneev commented 2025-05-21 11:27:18 +03:00
Member
Copy Link

Pull Request template

Please, go through these steps before clicking submit on this PR.

  1. Give a descriptive title to your PR.
  2. Provide a description of your changes.
  3. Make sure you have some relevant tests.
  4. Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if applicable).

PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

## Pull Request template Please, go through these steps before clicking submit on this PR. 1. Give a descriptive title to your PR. 2. Provide a description of your changes. 3. Make sure you have some relevant tests. 4. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if applicable). **PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING**
devstigneev added 1 commit 2025-05-21 11:27:19 +03:00
added check span!=nil && conn close
Some checks failed
lint / lint (pull_request) Failing after 1m3s
Details
test / test (pull_request) Successful in 3m27s
Details
9dd6efddf9
devstigneev reviewed 2025-05-21 11:28:10 +03:00
kgo.go Outdated
@@ -287,6 +287,7 @@ func (k *Broker) publish(ctx context.Context, msgs []*broker.Message, opts ...br
k.Unlock()
return err
}
k.c.Close()
devstigneev commented 2025-05-21 11:28:10 +03:00
Author
Member
Copy Link

такое не прокатит? если открыли новый коннект - попробовать закрыть текущий

такое не прокатит? если открыли новый коннект - попробовать закрыть текущий
devstigneev added 1 commit 2025-05-21 11:36:39 +03:00
removed reconn
Some checks failed
lint / lint (pull_request) Failing after 56s
Details
test / test (pull_request) Successful in 2m28s
Details
397f5414b3
vtolstov merged commit ff7a88fcce into v3 2025-05-21 11:56:48 +03:00
vtolstov deleted branch v3 2025-05-21 11:56:49 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
atolstikhin devstigneev pugnack vtolstov
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unistack-org/micro-broker-kgo#154
No description provided.
Delete Branch "devstigneev/micro-broker-kgo:v3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?