unistack-org/micro-broker-kgo
4
0
Fork 2
Code Issues 4 Pull Requests 3 Actions 1 Packages Projects Releases 83 Wiki Activity

fix consume/killconsume #157

Open
devstigneev wants to merge 4 commits from devstigneev/micro-broker-kgo:v4_fix into v4
pull from: devstigneev/micro-broker-kgo:v4_fix
merge into: unistack-org:v4
Conversation 2 Commits 4 Files Changed 2 +55 -21
devstigneev commented 2025-11-27 13:15:36 +03:00
Member
Copy Link

Pull Request template

Please, go through these steps before clicking submit on this PR.

  1. Give a descriptive title to your PR.
  2. Provide a description of your changes.
  3. Make sure you have some relevant tests.
  4. Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if applicable).

PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

## Pull Request template Please, go through these steps before clicking submit on this PR. 1. Give a descriptive title to your PR. 2. Provide a description of your changes. 3. Make sure you have some relevant tests. 4. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if applicable). **PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING**
devstigneev added 1 commit 2025-11-27 13:15:37 +03:00
fix consume/killconsume
Some checks failed
coverage / build (pull_request) Failing after 3m29s
Details
lint / lint (pull_request) Failing after 4m59s
Details
test / test (pull_request) Failing after 18m36s
Details
28cb71af46
devstigneev added 2 commits 2025-12-05 15:35:42 +03:00
fix consume/killconsume ea7ac4378a
Merge remote-tracking branch 'fork/v4_fix' into v4_fix
Some checks failed
coverage / build (pull_request) Failing after 1m24s
Details
lint / lint (pull_request) Failing after 1m14s
Details
test / test (pull_request) Failing after 2m33s
Details
553f729b25 
# Conflicts:
#	subscriber.go
devstigneev added 1 commit 2025-12-05 15:38:57 +03:00
removed old version golangcylint.yaml
Some checks failed
lint / lint (pull_request) Failing after 1m27s
Details
coverage / build (pull_request) Failing after 1m33s
Details
test / test (pull_request) Failing after 17m0s
Details
bd97d3416e
vtolstov approved these changes 2025-12-06 13:13:54 +03:00
Dismissed
subscriber.go
@@ -166,0 +177,4 @@
s.kopts.Logger.Debug(ctx, fmt.Sprintf("[kgo] consumer stopped topic %s partition %d", t, p))
}
case <-timeout.C:
s.kopts.Logger.Error(ctx, fmt.Sprintf("[kgo] timeout waiting for consumer topic %s partition %d", t, p))
vtolstov commented 2025-12-06 13:13:46 +03:00
Owner
Copy Link

вынести юзеру и убрать лог

вынести юзеру и убрать лог
subscriber.go
@@ -305,3 +328,1 @@
err = h(pm)
case func([]broker.Message) error:
err = h([]broker.Message{pm})
processCtx, cancel := context.WithTimeout(ctx, 30*time.Second) //waiting process consumer mb set to opts/cfg TimeoutProccesWaitingHandle
vtolstov commented 2025-12-06 13:10:47 +03:00
Owner
Copy Link

давай в брокер добавим https://git.unistack.org/unistack-org/micro/src/branch/v4/server/options.go#L77
грейсфул таймаут, и тут его будем использовать

давай в брокер добавим https://git.unistack.org/unistack-org/micro/src/branch/v4/server/options.go#L77 грейсфул таймаут, и тут его будем использовать
subscriber.go
@@ -308,0 +340,4 @@
select {
case err = <-errChan:
case <-processCtx.Done():
err = fmt.Errorf("[kgo] message processing timeout topic %s partition %d offset %d", record.Topic, record.Partition, record.Offset)
vtolstov commented 2025-12-06 13:12:56 +03:00
Owner
Copy Link

тут лучше возвращать context.ErrTimeout

тут лучше возвращать context.ErrTimeout
subscriber.go
@@ -335,6 +372,8 @@ func (pc *consumer) consume() {
continue
}
pc.kopts.Logger.Error(pc.kopts.Context, fmt.Sprintf("[kgo] message not acknowledged topic %s partition %d offset %d", record.Topic, record.Partition, record.Offset))
vtolstov commented 2025-12-06 13:12:07 +03:00
Owner
Copy Link

это на дебаг левел, так как обработка ошибок перенесена на юзера

это на дебаг левел, так как обработка ошибок перенесена на юзера
vtolstov requested changes 2025-12-06 13:14:16 +03:00
vtolstov left a comment
Owner
Copy Link

пару моментов поправить

пару моментов поправить
Some checks failed
lint / lint (pull_request) Failing after 1m27s
Details
coverage / build (pull_request) Failing after 1m33s
Details
test / test (pull_request) Failing after 17m0s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u v4_fix:devstigneev-v4_fix
git checkout devstigneev-v4_fix
Sign in to join this conversation.
Reviewers
No Reviewers
vtolstov
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
atolstikhin devstigneev pugnack vtolstov
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unistack-org/micro-broker-kgo#157
Delete Branch "devstigneev/micro-broker-kgo:v4_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?