unistack-org/micro-client-grpc
4
0
Fork 2
Code Issues Pull Requests Actions Packages Projects Releases 40 Wiki Activity

prepare v4 #139

Merged
vtolstov merged 10 commits from devstigneev/micro-client-grpc:prepare_v4 into v4 2025-03-03 09:53:41 +03:00
Conversation 1 Commits 10 Files Changed 11 +122 -219
devstigneev commented 2025-02-25 17:16:13 +03:00
Member
Copy Link

Pull Request template

Please, go through these steps before clicking submit on this PR.

  1. Give a descriptive title to your PR.
  2. Provide a description of your changes.
  3. Make sure you have some relevant tests.
  4. Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if applicable).

PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

## Pull Request template Please, go through these steps before clicking submit on this PR. 1. Give a descriptive title to your PR. 2. Provide a description of your changes. 3. Make sure you have some relevant tests. 4. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if applicable). **PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING**
devstigneev added 1 commit 2025-02-25 17:16:13 +03:00
prepare v4
Some checks failed
lint / lint (pull_request) Failing after 1m41s
Details
test / test (pull_request) Successful in 3m19s
Details
7969cfd8c9
devstigneev added 1 commit 2025-02-26 22:06:40 +03:00
removed publshing
Some checks failed
lint / lint (pull_request) Failing after 1m15s
Details
test / test (pull_request) Successful in 2m9s
Details
1f8a64c7d6
vtolstov requested changes 2025-02-26 23:41:58 +03:00
go.mod Outdated
@@ -1,8 +1,22 @@
module go.unistack.org/micro-client-grpc/v3
vtolstov commented 2025-02-26 23:37:29 +03:00
Owner
Copy Link

v4

v4
👍 1
grpc.go Outdated
@@ -477,4 +468,2 @@
gcall := g.call
// wrap the call in reverse
for i := len(callOpts.CallWrappers); i > 0; i-- {
vtolstov commented 2025-02-26 23:41:12 +03:00
Owner
Copy Link

тут видимо хуки должны быть?

тут видимо хуки должны быть?
👍 1
grpc.go Outdated
@@ -87,3 +85,1 @@
header["Grpc-Timeout"] = fmt.Sprintf("%dn", opts.RequestTimeout)
header["timeout"] = fmt.Sprintf("%dn", opts.RequestTimeout)
header["content-type"] = req.ContentType()
header["Grpc-Timeout"] = append(header["Grpc-Timeout"], fmt.Sprintf("%dn", opts.RequestTimeout))
vtolstov commented 2025-02-26 23:38:37 +03:00
Owner
Copy Link

в нижнем регистре

в нижнем регистре
👍 1
grpc.go Outdated
@@ -90,2 +87,3 @@
header["content-type"] = append(header["content-type"], req.ContentType())
md := gmetadata.New(header)
md := gmetadata.MD(metadata.Copy(header))
vtolstov commented 2025-02-26 23:40:01 +03:00
Owner
Copy Link

по идее типы одинаковые type MD map[string][]string
make а потом copy

по идее типы одинаковые type MD map[string][]string make а потом copy
👍 1
vtolstov changed target branch from master to v4 2025-02-26 23:42:10 +03:00
devstigneev added 1 commit 2025-02-27 18:35:32 +03:00
correcting grpc.go
Some checks failed
lint / lint (pull_request) Failing after 1m52s
Details
test / test (pull_request) Successful in 3m27s
Details
11e3ab33b5
devstigneev added 4 commits 2025-03-03 09:38:41 +03:00
prepare v4 5a9b5e23fc
removed publshing 80a95aae8f
correcting grpc.go c47d04db7f
Merge remote-tracking branch 'fork/prepare_v4' into prepare_v4
Some checks failed
lint / lint (pull_request) Failing after 1m13s
Details
test / test (pull_request) Successful in 2m41s
Details
7ad92816ef 
# Conflicts:
#	codec.go
devstigneev added 1 commit 2025-03-03 09:44:42 +03:00
resolve conflict
All checks were successful
lint / lint (pull_request) Successful in 1m13s
Details
test / test (pull_request) Successful in 2m2s
Details
36c52990ee
devstigneev force-pushed prepare_v4 from 36c52990ee to b809959065 2025-03-03 09:48:07 +03:00 Compare
vtolstov merged commit 75437a46c8 into v4 2025-03-03 09:53:41 +03:00
vtolstov deleted branch prepare_v4 2025-03-03 09:53:41 +03:00
vtolstov referenced this issue from a commit 2025-03-03 09:53:43 +03:00
prepare v4 (#139)
Sign in to join this conversation.
Reviewers
No Reviewers
vtolstov
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
atolstikhin devstigneev pugnack vtolstov
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unistack-org/micro-client-grpc#139
No description provided.
Delete Branch "devstigneev/micro-client-grpc:prepare_v4"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?