unistack-org/micro-server-tcp
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases 12 Wiki Activity

[BUG] graceful shutdown #130

New Issue
Closed
opened 2024-02-25 12:39:28 +03:00 by vtolstov · 0 comments
vtolstov commented 2024-02-25 12:39:28 +03:00
Owner
Copy Link

нужно реализовать механизм грейсфул шатдауна. видимо нужно трекать через wg.Add/wg.Done коннекты которые мы за-акцептили,
https://eli.thegreenplace.net/2020/graceful-shutdown-of-a-tcp-server-in-go/ - пример. мне скорее подходит последний вариант, где мы не закрываем тех кто активно читает ответ. нужно понять можем ли реализовать.

пулл реквест нужно сделать для мастер ветки и дл v3 , опцию завести в micro/server/options.go

нужно реализовать механизм грейсфул шатдауна. видимо нужно трекать через wg.Add/wg.Done коннекты которые мы за-акцептили, https://eli.thegreenplace.net/2020/graceful-shutdown-of-a-tcp-server-in-go/ - пример. мне скорее подходит последний вариант, где мы не закрываем тех кто активно читает ответ. нужно понять можем ли реализовать. пулл реквест нужно сделать для мастер ветки и дл v3 , опцию завести в micro/server/options.go
devstigneev was assigned by vtolstov 2024-02-25 12:39:35 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees devstigneev
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unistack-org/micro-server-tcp#130
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?