unistack-org/micro
4
0
Fork 3
Code Issues 19 Pull Requests 1 Actions Packages Projects Releases 259 Wiki Activity

prefix in consul api starts with no leading slash

Browse Source 
When `consul.StripPrefix(true)` is set, current impl. will pass the
specified prefix (or default prefix) when calling consul api.

However, `prefix` in consul api starts with no leading slash, so
the default prefix (`/micro/config`) doesn't actually work.

I avoid code changes (esp. the one in `util.go`) to eliminate
impact on users who already notice it.
This commit is contained in:
magodo 2019-06-19 14:42:09 +08:00
parent 73a8b14145
commit 606b1ff7cf
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
config/source/consul/README.md
View File

@ -4,7 +4,7 @@ The consul source reads config from consul key/values
## Consul Format ## Consul Format
The consul source expects keys under the default prefix `/micro/config` The consul source expects keys under the default prefix `micro/config`
Values are expected to be json Values are expected to be json
@ -29,8 +29,8 @@ Specify source with data
consulSource := consul.NewSource( consulSource := consul.NewSource(
// optionally specify consul address; default to localhost:8500 // optionally specify consul address; default to localhost:8500
consul.WithAddress("10.0.0.10:8500"), consul.WithAddress("10.0.0.10:8500"),
// optionally specify prefix; defaults to /micro/config // optionally specify prefix; defaults to micro/config
consul.WithPrefix("/my/prefix"), consul.WithPrefix("my/prefix"),
// optionally strip the provided prefix from the keys, defaults to false // optionally strip the provided prefix from the keys, defaults to false
consul.StripPrefix(true), consul.StripPrefix(true),
) )

2
config/source/consul/consul.go
View File

@ -21,7 +21,7 @@ type consul struct {
var ( var (
// DefaultPrefix is the prefix that consul keys will be assumed to have if you // DefaultPrefix is the prefix that consul keys will be assumed to have if you
// haven't specified one // haven't specified one
DefaultPrefix = "/micro/config/" DefaultPrefix = "micro/config/"
) )
func (c *consul) Read() (*source.ChangeSet, error) { func (c *consul) Read() (*source.ChangeSet, error) {