unistack-org/micro
4
0
Fork 3
Code Issues 20 Pull Requests 1 Actions Packages Projects Releases 280 Wiki Activity

WIP: Add testcase && hook logger for server #360

Closed
devstigneev wants to merge 1 commits from devstigneev/micro:log_hooks into v3
pull from: devstigneev/micro:log_hooks
merge into: unistack-org:v3
Conversation 1 Commits 1 Files Changed 6 +241 -36
devstigneev commented 2024-11-24 01:16:28 +03:00
Member
Copy Link

Pull Request template

Please, go through these steps before clicking submit on this PR.

  1. Give a descriptive title to your PR.
  2. Provide a description of your changes.
  3. Make sure you have some relevant tests.
  4. Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if applicable).

PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

## Pull Request template Please, go through these steps before clicking submit on this PR. 1. Give a descriptive title to your PR. 2. Provide a description of your changes. 3. Make sure you have some relevant tests. 4. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if applicable). **PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING**
devstigneev added 1 commit 2024-11-24 01:16:28 +03:00
Add testcase && hook logger for server
Some checks failed
lint / lint (pull_request) Has been cancelled
Details
pr / test (pull_request) Has been cancelled
Details
f33dcd628a
devstigneev changed title from Add testcase && hook logger for server to WIP: Add testcase && hook logger for server 2024-11-24 01:16:41 +03:00
devstigneev reviewed 2024-11-24 01:18:35 +03:00
logger/slog/slog_test.go
@ -238,0 +244,4 @@
if err := log.Init(); err != nil {
t.Fatal(err)
}
log = log.Fields("key", "val")
devstigneev commented 2024-11-24 01:18:35 +03:00
Author
Member
Copy Link

Fields просто прокидываются в handler

Если использовать опцию WithFields они будут склонированы, тк хранятся в самой опции

Fields просто прокидываются в handler Если использовать опцию WithFields они будут склонированы, тк хранятся в самой опции
devstigneev reviewed 2024-11-24 01:20:59 +03:00
logger/slog/slog_test.go
@ -238,0 +246,4 @@
}
log = log.Fields("key", "val")
nlog := log.Clone(logger.WithLevel(logger.InfoLevel))
devstigneev commented 2024-11-24 01:20:59 +03:00
Author
Member
Copy Link

метод клон, аналогичен методу филдс

причина: аттррибуты пишутся только в сам хендлер слога, которые уже не копируются

https://git.unistack.org/devstigneev/micro/src/branch/log_hooks/logger/slog/slog.go#L130

метод клон, аналогичен методу филдс причина: аттррибуты пишутся только в сам хендлер слога, которые уже не копируются [https://git.unistack.org/devstigneev/micro/src/branch/log_hooks/logger/slog/slog.go#L130]()
vtolstov commented 2024-11-24 15:48:20 +03:00
Owner
Copy Link

поправил в v3.10.102

поправил в v3.10.102
vtolstov closed this pull request 2024-11-24 15:48:21 +03:00
Some checks failed
lint / lint (pull_request) Has been cancelled
Details
pr / test (pull_request) Has been cancelled
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unistack-org/micro#360
No description provided.
Delete Branch "devstigneev/micro:log_hooks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?