Release v1.0.7

Rebuild for #28
Merge pull request #28 from dedesite/patch-1
2017-03-20 10:27:27 +01:00 · 2017-03-20 10:27:12 +01:00 · 2017-03-20 10:26:46 +01:00 · 2017-03-20 10:20:04 +01:00 · 2017-03-17 14:25:20 +01:00
6 changed files with 17 additions and 9 deletions
--- a/bower.json
+++ b/bower.json
@@ -1,6 +1,6 @@
 {
  "name": "pofile",
-  "version": "1.0.6",
+  "version": "1.0.7",
  "authors": [
    "Ruben Vermeersch <ruben@rocketeer.be>"
  ],
--- a/dist/pofile.js
+++ b/dist/pofile.js
@@ -23,12 +23,12 @@ PO.prototype.toString = function () {

    if (this.comments) {
        this.comments.forEach(function (comment) {
-            lines.push('# ' + comment);
+            lines.push(('# ' + comment).trim());
        });
    }
    if (this.extractedComments) {
        this.extractedComments.forEach(function (comment) {
-            lines.push('#. ' + comment);
+            lines.push(('#. ' + comment).trim());
        });
    }

--- a/dist/pofile.min.js
+++ b/dist/pofile.min.js
--- a/lib/po.js
+++ b/lib/po.js
@@ -20,12 +20,12 @@ PO.prototype.toString = function () {

    if (this.comments) {
        this.comments.forEach(function (comment) {
-            lines.push('# ' + comment);
+            lines.push(('# ' + comment).trim());
        });
    }
    if (this.extractedComments) {
        this.extractedComments.forEach(function (comment) {
-            lines.push('#. ' + comment);
+            lines.push(('#. ' + comment).trim());
        });
    }

--- a/package.json
+++ b/package.json
@@ -1,7 +1,7 @@
 {
  "name": "pofile",
  "description": "Parse and serialize Gettext PO files.",
-  "version": "1.0.6",
+  "version": "1.0.7",
  "author": {
    "name": "Ruben Vermeersch",
    "email": "ruben@savanne.be",
--- a/test/write.js
+++ b/test/write.js
@@ -2,12 +2,13 @@ var assert = require('assert');
 var fs = require('fs');
 var PO = require('..');

-function assertHasLine(str, line) {
+function assertHasLine(str, line, doNotTrim) {
    var lines = str.split('\n');
    var found = false;

    for (var i = 0; i < lines.length; i++) {
-        if (lines[i].trim() === line) {
+        var lineToCompare = doNotTrim ? lines[i] : lines[i].trim();
+        if (lineToCompare === line) {
            found = true;
            break;
        }
@@ -53,6 +54,13 @@ describe('Write', function () {
        assertHasLine(str, '#, fuzzy');
    });

+    it('write empty comment without an unecessary space', function () {
+        var input = fs.readFileSync(__dirname + '/fixtures/fuzzy.po', 'utf8');
+        var po = PO.parse(input);
+        var str = po.toString();
+        assertHasLine(str, '#', true);
+    });
+
    it('write flags only when true', function () {
        var input = fs.readFileSync(__dirname + '/fixtures/fuzzy.po', 'utf8');
        var po = PO.parse(input);
Author	SHA1	Message	Date
Ruben Vermeersch	ff0e5655f9	Release v1.0.7	2017-03-20 10:27:27 +01:00
Ruben Vermeersch	bb56f6e34c	Rebuild for #28	2017-03-20 10:27:12 +01:00
Ruben Vermeersch	f035affef6	Merge pull request #28 from dedesite/patch-1 Avoid putting a space in empty comments	2017-03-20 10:26:46 +01:00
Andréas Livet	18a4cc0cb5	Add test to ensure no spaces are added on empty comments	2017-03-20 10:20:04 +01:00
Andréas Livet	0fcff887fe	Avoid putting a space in empty comments In our pipeline, empty comments in po files are generated without a space after '#' and saving a po file using pofile lib generates unwanted diff that need to be handle manually which is really annoying. This pull request simply trim the comment line.	2017-03-17 14:25:20 +01:00