#1 #5

Merged
vtolstov merged 4 commits from kgorbunov/servicechecker:#1 into master 2024-11-24 12:57:54 +03:00
Member
No description provided.
kgorbunov added 2 commits 2024-11-21 15:14:35 +03:00
kgorbunov added spent time 2024-11-21 15:14:43 +03:00
3 hours
kgorbunov added 1 commit 2024-11-22 12:19:09 +03:00
vtolstov requested changes 2024-11-22 13:04:31 +03:00
@ -0,0 +29,4 @@
}
func (p *ProtoSet) GetMessage(addr, pkg, svc, mth string) (protoreflect.Message, protoreflect.Message, error) {
if addr == "" || svc == "" || mth == "" {
Owner

проверку pkg пропустил, по факту все 4 параметра тут обязательные.

проверку pkg пропустил, по факту все 4 параметра тут обязательные.
@ -0,0 +63,4 @@
func (p *ProtoSet) AddProtoset(addr, svc string, data []byte) error {
fdset := &descriptorpb.FileDescriptorSet{}
if err := protocodec.NewCodec().Unmarshal(data, fdset); err != nil {
return fmt.Errorf("failed to unmarshal protoset file: %s", err)
Owner

такие штуки fmt.Errorf("failed to unmarshal protoset file: %s", err) лучше через
fmt.Errorf("failed to unmarshal protoset file: %w", err) делать, чтобы оно врапало исходную ошибку.

такие штуки fmt.Errorf("failed to unmarshal protoset file: %s", err) лучше через fmt.Errorf("failed to unmarshal protoset file: %w", err) делать, чтобы оно врапало исходную ошибку.
@ -0,0 +6,4 @@
"os"
"testing"
. "github.com/smartystreets/goconvey/convey"
Owner

вот этоу лучше на testify

вот этоу лучше на [testify](https://github.com/stretchr/testify)
kgorbunov added 1 commit 2024-11-22 13:42:29 +03:00
vtolstov merged commit ce57938ec2 into master 2024-11-24 12:57:54 +03:00
vtolstov referenced this issue from a commit 2024-11-24 12:57:55 +03:00
vtolstov deleted branch #1 2024-11-24 12:57:55 +03:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Total Time Spent: 3 hours
kgorbunov
3 hours
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: unistack-org/servicechecker#5
No description provided.