#1 #5
2 Participants
Notifications
Total Time Spent: 3 hours
Due Date
kgorbunov
3 hours
No due date set.
Dependencies
No dependencies set.
Reference: unistack-org/servicechecker#5
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "kgorbunov/servicechecker:#1"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -0,0 +29,4 @@
}
func (p *ProtoSet) GetMessage(addr, pkg, svc, mth string) (protoreflect.Message, protoreflect.Message, error) {
if addr == "" || svc == "" || mth == "" {
проверку pkg пропустил, по факту все 4 параметра тут обязательные.
@ -0,0 +63,4 @@
func (p *ProtoSet) AddProtoset(addr, svc string, data []byte) error {
fdset := &descriptorpb.FileDescriptorSet{}
if err := protocodec.NewCodec().Unmarshal(data, fdset); err != nil {
return fmt.Errorf("failed to unmarshal protoset file: %s", err)
такие штуки fmt.Errorf("failed to unmarshal protoset file: %s", err) лучше через
fmt.Errorf("failed to unmarshal protoset file: %w", err) делать, чтобы оно врапало исходную ошибку.
@ -0,0 +6,4 @@
"os"
"testing"
. "github.com/smartystreets/goconvey/convey"
вот этоу лучше на testify